refactor: add import-linter baseline gate#38347
Draft
QuantumGhost wants to merge 12 commits into
Draft
Conversation
Assisted-by: Codex:GPT-5.4
QuantumGhost
added
refactor
python
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-07-02 18:12:18.924434600 +0000
+++ /tmp/pyrefly_pr.txt 2026-07-02 18:12:10.069319530 +0000
@@ -1,3 +1,9 @@
+ERROR Cannot set item in `dict[str, dict[str, set[str]]]` [unsupported-operation]
+ --> dev/lint_imports_baseline.py:74:39
+ERROR Returned type `dict[str, dict[str, set[str]]]` is not assignable to declared return type `dict[str, dict[str, list[str]]]` [bad-return]
+ --> dev/lint_imports_baseline.py:78:12
+ERROR Argument `DataclassInstance | type[DataclassInstance]` is not assignable to parameter `obj` with type `DataclassInstance` in function `dataclasses.asdict` [bad-argument-type]
+ --> dev/lint_imports_baseline.py:228:60
ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `dify_vdb_alibabacloud_mysql.alibabacloud_mysql_vector.AlibabaCloudMySQLVectorFactory.init_vector` [bad-argument-type]
--> providers/vdb/vdb-alibabacloud-mysql/tests/unit_tests/test_alibabacloud_mysql_factory.py:42:38
ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `dify_vdb_alibabacloud_mysql.alibabacloud_mysql_vector.AlibabaCloudMySQLVectorFactory.init_vector` [bad-argument-type]
|
Contributor
Pyrefly Type Coverage
|
QuantumGhost
changed the title
Assisted-by: Codex:GPT-5.4
Assisted-by: Codex:GPT-5.4
Assisted-by: Codex:GPT-5.4
Assisted-by: Codex:GPT-5.4
Assisted-by: Codex:GPT-5.4
Assisted-by: Codex:GPT-5.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI disclosure: This PR was primarily drafted with Codex using GPT-5.4. I have not reviewed and the final diff yet.
Important
Fixes #<issue number>.Summary
Fixes #38346.
This PR adds a small baseline gate around
import-linterso layered-architecture refactors can be adopted incrementally in legacy backend packages.api/dev/lint_imports_baseline.pyto convert brokenimport-lintercontract metadata into a stable violation snapshotsubsetmode (default) andcountmode, withsubsetused as the safer non-regression policymake lintviaapi-import-baseline-lintValidation used for this change:
uv run --project api pytest api/tests/unit_tests/commands/test_lint_imports_baseline.py -quv run --project api --dev python api/dev/lint_imports_baseline.py --baseline api/dev/import_linter_baseline.jsonuv run --project api --dev ruff check api/dev/lint_imports_baseline.py api/tests/unit_tests/commands/test_lint_imports_baseline.pyScreenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsFrom Codex